[bug #44891] gropdf use of Compress::Zlib is not documented as a dependency

[Werner LEMBERG]

Update of bug #44891 (project groff):

Assigned to: None => deri

_______________________________________________________

Follow-up Comment #1:

Given that Perl 5.10 appeared in 2007, requesting this version would be
simplest. However, I'm not sure whether we can expect this to be available on
older hosts...

Making gropdf use Compress::Zlib only if it is available (and emitting a big
fat warning otherwise) is probably the way to go.

Deri?

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?44891>

_______________________________________________
Nachricht gesendet von/durch Savannah
http://savannah.gnu.org/

[Deri James]

Follow-up Comment #2, bug #44891 (project groff):

Gropdf uses Zlib in two places, once when writing a "stream", and again when
reading a stream (happens when you insert a graphic which is a pdf file). In
both cases I don't think it is absolutely necessary, if you use the -d flag
pdfs are not compressed anyway, and on reading pdfs if a different compression
other than deflate is used then it just leaves it alone and passes it "as is"
to the writer.

So I will make a change which checks for Compress::Zlib and if not found
outputs a suitable warning to stderr but continues to produce an uncompressed
pdf as if the -d flag was set.

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?44891>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/

[Deri James]

Follow-up Comment #3, bug #44891 (project groff):

I have pushed a fix to git please can you test on Solaris.

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?44891>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/

[Peter Bray]

Follow-up Comment #4, bug #44891 (project groff):

Deri,

Looks good. Below is a single example of the code in action, from a system
that does not have (first example) and has (second
example) the Compress::Zlib module.

Many Thanks,
Peter

Solaris10Update8 % gmake ./contrib/mom/examples/letter.pdf
LC_ALL=C GROFF_COMMAND_PREFIX= GROFF_BIN_PATH="/tmp/64-bit/groff-1.22.3"
PDFMOM_BIN_PATH="." /tmp/64-bit/groff-1.22.3/pdfmom
-F/tmp/64-bit/groff-1.22.3/font -F/tmp/64-bit/groff-1.22.3/font
-M/tmp/64-bit/groff-1.22.3/tmac -M/tmp/64-bit/groff-1.22.3/tmac
-M./contrib/mom -M./contrib/mom -k contrib/mom/examples/letter.mom

contrib/mom/examples/letter.pdf

Perl module Compress::Zlib not available - cannot compress this pdf

Solaris11Update2 % gmake ./contrib/mom/examples/letter.pdf
LC_ALL=C GROFF_COMMAND_PREFIX= GROFF_BIN_PATH="/tmp/64-bit/groff-1.22.3"
PDFMOM_BIN_PATH="." /tmp/64-bit/groff-1.22.3/pdfmom
-F/tmp/64-bit/groff-1.22.3/font -F/tmp/64-bit/groff-1.22.3/font
-M/tmp/64-bit/groff-1.22.3/tmac -M/tmp/64-bit/groff-1.22.3/tmac
-M./contrib/mom -M./contrib/mom -k contrib/mom/examples/letter.mom

contrib/mom/examples/letter.pdf

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?44891>

_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/

[G. Branden Robinson]

Update of bug #44891 (project groff):

Category: None => Device gropdf
Status: None => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.22.4

_______________________________________________________

Follow-up Comment #5:

This was fixed in commit cc4e05054c93177b0574154cc78af06a1b4cc7a6 back on
2015-04-22 and released in groff 1.22.4.

_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/bugs/?44891>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/