[bug #58337] negative arguments to .ss request cause assertion failure

[G. Branden Robinson]

URL:
<https://savannah.gnu.org/bugs/?58337>

Summary: negative arguments to .ss request cause assertion
failure
Project: GNU troff
Submitted by: gbranden
Submitted on: Fri 08 May 2020 10:44:27 PM UTC
Category: Core
Severity: 3 - Normal
Item Group: Crash/Not responding
Status: In Progress
Privacy: Public
Assigned to: gbranden
Open/Closed: Open
Discussion Lock: Any
Planned Release: None

_______________________________________________________

Details:

I didn't think my C99-conformant assert() rewrite would pay off this quickly.


$ ./build/test-groff -Tutf8
.ss 12 -1
a
troff: ../src/roff/troff/number.cpp:653: scale(): assertion failed: 'x >= 0 &&
y > 0'
[...]/build/groff: error: troff: Signal 6 (core dumped)


Same happens if the arguments to .ss are swapped.

Seems like we should just reject negative values for these parameters.

Zeroes are fine. They result in ugly typography (for conventional
applications), but they don't crash groff.




_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/bugs/?58337>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

[G. Branden Robinson]

Update of bug #58337 (project groff):

Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.22.5

_______________________________________________________

Follow-up Comment #1:

Fixed in c3047d8f5881e21cf4f09c13d88106c71aa25004.

_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/bugs/?58337>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/